winmm: MCI_SYSINFO dwRetSize counts characters, not bytes.

Joerg-Cyril.Hoehle at Joerg-Cyril.Hoehle at
Fri Apr 16 04:01:11 CDT 2010


you might object that the tests herein only stress one of several
MCI_SYSINFO_ code paths, namely MCI_SYSINFO_NAME | OPEN.

I've since tested the MCI_SYSINFO_INSTALLNAME option as well, but
those tests are part of another set I'm slowly preparing, not herein.
They react the same as here.

A PARAM_OVERFLOW test about MCI_SYSINFO_QUANTITY is already in tests/mci.c,
but that does not involve character buffers and is treated differently.
My recent A/W-mapping patch already took that into account.

So the only untested option is MCI_SYSINFO_NAME without OPEN.  For
consistency, let's believe it works like the other string returning
options.  I believe there are more important tests yet to write
than to achieve 100% branch coverage in this particular area.

	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-winmm-MCI_SYSINFO-dwRetSize-counts-characters-not.patch
Type: application/octet-stream
Size: 7265 bytes
Desc: 0001-winmm-MCI_SYSINFO-dwRetSize-counts-characters-not.patch
URL: <>

More information about the wine-patches mailing list