winex11: keyboard.c requires a 1 byte : 1 char encoding, not UTF-8.

Joerg-Cyril.Hoehle at Joerg-Cyril.Hoehle at
Thu Apr 29 03:18:51 CDT 2010


this reverts AJ's 2008-10-18 commit f62ac19fb537f4608f4b7c3f6f6186b8d9a67ef7
w.r.t. keyboard.c. Perhaps that's reason enough to reject it :-)

My rationale is that a file with mixed encodings -- UTF-8 in comments
and ISO-8859-X (actually whatever 1:1 encoding is required to display
the keyboard's characters) within strings will break havoc in most
editors (even Emacs).

Of course, the robust patch would be instead to convert all 1 byte long ISO-8859-X
characters to \x hexadecimal C notation. Then the comments in the file
could be written using any encoding.
Alas the \xAB would be hard to review.

Here's the trivial "revert UTF-8" patch. Committing or not is your decision only.

 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-winex11-keyboard.c-requires-a-1-byte-1-char-encod.patch
Type: application/octet-stream
Size: 1564 bytes
Desc: 0001-winex11-keyboard.c-requires-a-1-byte-1-char-encod.patch
URL: <>

More information about the wine-patches mailing list