[PATCH] kernel32: change fixme to trace in comm.c

Wolfram Sang wolfram at the-dreams.de
Mon Aug 9 05:15:50 CDT 2010


The only FIXME in comm.c does not point out a special case or something
worth fixing. In fact, it looks more like all the other TRACE occasions
in this source, so convert it to such. Discovered while working with an
application utilizing the serial port throwing lots of those fixmes.

While we are here, drop a superfluous setting of a struct member to 0
(the whole struct is zeroed at the beginning).

Signed-off-by: Wolfram Sang <wolfram at the-dreams.de>
---
 dlls/kernel32/comm.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/comm.c b/dlls/kernel32/comm.c
index f4edfd3..9653d6e 100644
--- a/dlls/kernel32/comm.c
+++ b/dlls/kernel32/comm.c
@@ -1138,7 +1138,7 @@ BOOL WINAPI GetCommProperties(
     HANDLE hFile,          /* [in] handle of the comm port */
     LPCOMMPROP lpCommProp) /* [out] pointer to struct to be filled */
 {
-    FIXME("(%p %p )\n",hFile,lpCommProp);
+    TRACE("(%p %p)\n",hFile,lpCommProp);
     if(!lpCommProp)
         return FALSE;
 
@@ -1150,7 +1150,6 @@ BOOL WINAPI GetCommProperties(
     lpCommProp->wPacketLength       = 1;
     lpCommProp->wPacketVersion      = 1;
     lpCommProp->dwServiceMask       = SP_SERIALCOMM;
-    lpCommProp->dwReserved1         = 0;
     lpCommProp->dwMaxTxQueue        = 4096;
     lpCommProp->dwMaxRxQueue        = 4096;
     lpCommProp->dwMaxBaud           = BAUD_115200;
-- 
1.7.1




More information about the wine-patches mailing list