[PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance.

David Adam david.adam.cnrs at gmail.com
Wed Aug 11 05:12:23 CDT 2010


some comments about this patch
+    if (hr != S_OK) return FALSE;
+    else return TRUE;

could be simplified as
return SUCCEEDED(hr);

+    trace("HRESULT when creating instance (%x)\n", hr);
Since tests are assumed to pass, we dont care about debug informations.  So,
traces are useless in tests. [It is my opinion. Better developpers could
give an opposite opinion]

+    todo_wine ok(*(ULONG *)pDirectMusicPort != 0, "IDirectMusicPort not

Why is this cast useful?


2010/8/9 Austin Lund <austin.lund at gmail.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100811/e2f735e7/attachment.htm>

More information about the wine-patches mailing list