[PATCH 2/3] mcicda: Fix several return codes. (try 2)

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Fri Aug 13 09:56:54 CDT 2010


[try 2: I discovered that MCI_SET_AUDIO is not ignored everywhere, so TRACE it.
 (Since some machines ignore it, it's not worth a FIXME.)]

- ExitThread removed in favour of plain return, like AJ
  once suggested for mciwave (not worth its own patch).
- ERROR_NOT_SUPPORTED mapped to MCIERR_HARDWARE for the sake of MacOS.
  (there's no todo_wine_macos)
  Native seems to map any trouble to MCIERR_HARDWARE.
- range checks in MCI_PLAY;
- many other boundary cases aligned on native behaviour, according to tests
  (the delayed patch #4) and my experience with the MCI.

Upcoming patch: open d, open d:, open diable, open d:\X type cdaudio all work since w2k.

        Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mcicda-Fix-several-return-codes.patch
Type: application/octet-stream
Size: 9014 bytes
Desc: 0002-mcicda-Fix-several-return-codes.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100813/97c83854/attachment.obj>

More information about the wine-patches mailing list