advpakc/tests: Removed sign comparison warning in advpack tests

Marko Nikolic grkoma at gmail.com
Thu Aug 19 16:33:02 CDT 2010


Condition checks changed to use strlen instead of lstrlenA function.
This removes sign comparison warnings. Also fixed one type to remove
warning.
---
 dlls/advpack/tests/advpack.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/advpack/tests/advpack.c b/dlls/advpack/tests/advpack.c
index 3ead0f2..1345d72 100644
--- a/dlls/advpack/tests/advpack.c
+++ b/dlls/advpack/tests/advpack.c
@@ -130,7 +130,7 @@ static void delnode_test(void)
     HRESULT hr;
     HANDLE hn;
     CHAR currDir[MAX_PATH];
-    int currDirLen;
+    UINT currDirLen;
 
     /* Native DelNode apparently does not support relative paths, so we use
        absolute paths for testing */
@@ -446,7 +446,7 @@ static void translateinfstringex_test(void)
     ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
     ok(!lstrcmpi(buffer, PROG_FILES_ROOT),
            "Expected %s, got %s\n", PROG_FILES_ROOT, buffer);
-    ok(size == lstrlenA(PROG_FILES_ROOT)+1, "Expected size %d, got %d\n",
+    ok(size == strlen(PROG_FILES_ROOT)+1, "Expected size %d, got %d\n",
            lstrlenA(PROG_FILES_ROOT)+1, size);
 
     memset(buffer, 'a', APP_PATH_LEN);
@@ -457,7 +457,7 @@ static void translateinfstringex_test(void)
     ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
     ok(!lstrcmpi(buffer, PROG_FILES_ROOT),
            "Expected %s, got %s\n", PROG_FILES_ROOT, buffer);
-    ok(size == lstrlenA(PROG_FILES_ROOT)+1, "Expected size %d, got %d\n",
+    ok(size == strlen(PROG_FILES_ROOT)+1, "Expected size %d, got %d\n",
            lstrlenA(PROG_FILES_ROOT)+1, size);
 
     {
@@ -473,7 +473,7 @@ static void translateinfstringex_test(void)
         ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
         ok(!lstrcmpi(buffer, drive),
                "Expected %s, got %s\n", drive, buffer);
-        ok(size == lstrlenA(drive)+1, "Expected size %d, got %d\n",
+        ok(size == strlen(drive)+1, "Expected size %d, got %d\n",
                lstrlenA(drive)+1, size);
     }
 
@@ -531,7 +531,7 @@ static void translateinfstringex_test(void)
     ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
     ok(!lstrcmpi(buffer, PROG_FILES_ROOT),
            "Expected %s, got %s\n", PROG_FILES_ROOT, buffer);
-    ok(size == lstrlenA(PROG_FILES_ROOT)+1, "Expected size %d, got %d\n",
+    ok(size == strlen(PROG_FILES_ROOT)+1, "Expected size %d, got %d\n",
            lstrlenA(PROG_FILES_ROOT)+1, size);
 
     /* close the INF again */
-- 
1.7.0.4




More information about the wine-patches mailing list