[PATCH] shell32: Correctly construct the PIDL given to SHChangeNotify in AddFolder

Andrew Eikum aeikum at codeweavers.com
Fri Dec 3 11:50:12 CST 2010

The old PIDL was created "from scratch" by giving it to 
_ILCreateFromPath. Instead, we should append the new relative path to 
the end of this ShellFolder's root PIDL.  This prevents creating a PIDL 
in the wrong namespace.

This fixes bug 18606.

I tried making tests for this, but the way Windows creates a new folder 
through the shell is radically different from how Wine creates a new 
folder through the shell.  Windows XP's IContextMenu doesn't support the 
New Folder verb, while Wine's does.  Going down the rabbit hole of 
reworking the entire shell system to be more Windows-like just so I 
could make a test for this feature was getting pretty far out of scope.

  dlls/shell32/shfldr_fs.c |   30 ++++++++++++++++++++++++++----
  1 files changed, 26 insertions(+), 4 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-shell32-Correctly-construct-the-PIDL-given-to-SHChan.patch
Type: text/x-patch
Size: 1482 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20101203/44dc791b/attachment.bin>

More information about the wine-patches mailing list