Support comment node type in IXMLDOMNode_get_baseName

Nikolay Sivov bunglehead at gmail.com
Tue Feb 9 09:07:54 CST 2010


---
 dlls/msxml3/node.c         |    1 +
 dlls/msxml3/tests/domdoc.c |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index ebf865e..d486bd9 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -1626,6 +1626,7 @@ static HRESULT WINAPI xmlnode_get_baseName(
         r = S_OK;
         break;
     case XML_TEXT_NODE:
+    case XML_COMMENT_NODE:
         break;
     default:
         ERR("Unhandled type %d\n", This->node->type );
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index bc052be..3c5c53c 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -982,6 +982,12 @@ static void test_domdoc( void )
         ok(r == S_FALSE, "ret %08x\n", r );
         ok(nodeChild == NULL, "pLastChild not NULL\n");
 
+        /* baseName */
+        str = (BSTR)0xdeadbeef;
+        IXMLDOMComment_get_baseName(node_comment, &str);
+        ok(r == S_FALSE, "ret %08x\n", r );
+        ok(str == NULL, "Expected NULL\n");
+
         IXMLDOMComment_Release( node_comment );
     }
 
-- 
1.5.6.5


--=-vNc4qWnVVn+8WqS4qTtS--




More information about the wine-patches mailing list