tests: WINETEST_STRICT=1 disables broken().

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Wed Feb 24 02:47:23 CST 2010


Hi,

This patch allows to detect broken broken().  I.e. I remember a case
in the MCI where it turned out that the case marked broken() was
in fact the correct return code.

Broken() is dangerous because it silently allows Wine to do
something completely different from native:
ok(rc=Wine_RC || broken(rc==Native_RC), "yeah\n");

(Perhaps it would be good to add a note about this in the dev guides?)

Of course, the patch does not help where broken() masks out broken HW on XP/Vista.

It would be valuable if, from time to time, WTB on test.winehq
would run the XP/7/Vista tests with WINETEST_STRICT to assess how
close Wine really is to native behaviour.

I'm not 100% satisfied with WINETEST_STRICT. Beside
WINETEST_INTERACTIVE, I'm wondering whether it is time to
turn WINETEST_DEBUG into a bit field.  Then Greg, our
WTB hero, would not need to update the web GUI every
time a new env variable is proposed.  Then everybody could
easily submit WTB jobs in either strict or normal mode.

What do you think? I could rewrite the patch using
(winetest_debug & 0x08) or any other bit. Conceptually,
it's still some sort of debugging.

Regards,
 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-WINETEST_STRICT-1-disables-broken.patch
Type: application/octet-stream
Size: 1589 bytes
Desc: 0001-tests-WINETEST_STRICT-1-disables-broken.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100224/f65d8b11/attachment.obj>


More information about the wine-patches mailing list