[PATCH] kernel32: Check if buffer is NULL before derefencing it (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun Jan 3 07:46:07 CST 2010


Hi,

Check buffer being NULL ... (should not happen when len is non-0
actually, but check for it).

Ciao, Marcus
---
 dlls/kernel32/profile.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c
index b5f7c0f..26c6736 100644
--- a/dlls/kernel32/profile.c
+++ b/dlls/kernel32/profile.c
@@ -1171,7 +1171,7 @@ INT WINAPI GetPrivateProfileStringA( LPCSTR section, LPCSTR entry,
     retW = GetPrivateProfileStringW( sectionW.Buffer, entryW.Buffer,
                                      def_valW.Buffer, bufferW, len,
                                      filenameW.Buffer);
-    if (len)
+    if (len && buffer)
     {
         if (retW)
         {
-- 
1.5.6



More information about the wine-patches mailing list