[PATCH] setupapi: Avoid NULL dereference in error path (Coverity)

Marcus Meissner marcus at jet.franken.de
Fri Jan 8 02:20:34 CST 2010


Hi,

In the out of memory error path (from HeapALloc above)
this could lead to file NULL dereferenced. (New after
yesterdays commit).

Ciao, Marcus
---
 dlls/setupapi/parser.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/dlls/setupapi/parser.c b/dlls/setupapi/parser.c
index 7f581bd..828b580 100644
--- a/dlls/setupapi/parser.c
+++ b/dlls/setupapi/parser.c
@@ -860,6 +860,7 @@ static void free_inf_file( struct inf_file *file )
 {
     unsigned int i;
 
+    if (!file) return;
     for (i = 0; i < file->nb_sections; i++) HeapFree( GetProcessHeap(), 0, file->sections[i] );
     HeapFree( GetProcessHeap(), 0, file->filename );
     HeapFree( GetProcessHeap(), 0, file->sections );
-- 
1.5.6



More information about the wine-patches mailing list