[PATCH 9/9] Get rid of upper case converting helper

Nikolay Sivov bunglehead at gmail.com
Sun Jan 10 13:42:46 CST 2010


---
 dlls/msxml3/xmlelem.c |   18 ++----------------
 1 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/dlls/msxml3/xmlelem.c b/dlls/msxml3/xmlelem.c
index 93cc53a..b91722c 100644
--- a/dlls/msxml3/xmlelem.c
+++ b/dlls/msxml3/xmlelem.c
@@ -171,31 +171,17 @@ static HRESULT WINAPI xmlelem_Invoke(IXMLElement *iface, DISPID dispIdMember,
     return hr;
 }
 
-static inline BSTR str_dup_upper(BSTR str)
-{
-    INT len = (lstrlenW(str) + 1) * sizeof(WCHAR);
-    BSTR p = SysAllocStringLen(NULL, len);
-    if (p)
-    {
-        memcpy(p, str, len);
-        CharUpperW(p);
-    }
-    return p;
-}
-
 static HRESULT WINAPI xmlelem_get_tagName(IXMLElement *iface, BSTR *p)
 {
     xmlelem *This = impl_from_IXMLElement(iface);
-    BSTR temp;
 
     TRACE("(%p, %p)\n", iface, p);
 
     if (!p)
         return E_INVALIDARG;
 
-    temp = bstr_from_xmlChar(This->node->name);
-    *p = str_dup_upper(temp);
-    SysFreeString(temp);
+    *p = bstr_from_xmlChar(This->node->name);
+    CharUpperBuffW(*p, SysStringLen(*p));
 
     TRACE("returning %s\n", debugstr_w(*p));
 
-- 
1.5.6.5


--=-fum7Vma0mB7yu5k0OtYH--




More information about the wine-patches mailing list