kernel32: Loosen trailing \ requirement on GetVolumeInformationAW.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Thu Jul 8 03:54:31 CDT 2010


Hi,

This patch reverts Guy's commit f7e6777e6e19ca3be4b84f98baf22ef53ab19f96

The trailing backslash requirement causes all Ring-Protech protected
apps to fail, bug # 23355.

I don't know the history that motivated that change in 2009.  I hope
this won't be an instance of a bugfix that creates another bug.

The tests prove that not all calls without a trailing slash must fail.
So until we know more precisely the exact conditions, I feel it's
better to revert to the old behaviour that allowed the copy
protection scheme to work.

For instance, the tests could be extended to involve different roots
(currently most probably only C:\... is used, as the tests do not
assume the existence of another drive).

FWIW, on win95 the MCI refuses
open d:\ type cdaudio alias x
but accepts
open d: type cdaudio alias x
I don't know if that proves anything beside the fact that trailing
backslashes are not expected to work everywhere.

BTW, most relevant tests were not executed on win9x because of bad use
of win_skip.  My next patch fixes that.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-kernel32-Loosen-trailing-requirement-on-GetVolume.patch
Type: application/octet-stream
Size: 2715 bytes
Desc: 0001-kernel32-Loosen-trailing-requirement-on-GetVolume.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100708/4f4049dd/attachment.obj>


More information about the wine-patches mailing list