[PATCH 3/3] Fix a crash in TVS_SINGELEXPAND helper (Coverity)
Nikolay Sivov
nsivov at codeweavers.com
Wed Jul 28 04:55:31 CDT 2010
---
dlls/comctl32/tests/treeview.c | 5 +++++
dlls/comctl32/treeview.c | 2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c
index a0a3e23..0eb5c12 100644
--- a/dlls/comctl32/tests/treeview.c
+++ b/dlls/comctl32/tests/treeview.c
@@ -1255,6 +1255,11 @@ static void test_TVS_SINGLEEXPAND(void)
ok(ret, "got %d\n", ret);
ok_sequence(sequences, PARENT_SEQ_INDEX, parent_singleexpand_seq, "singleexpand notifications", FALSE);
+ ret = SendMessageA(hTree, TVM_EXPAND, TVE_COLLAPSE, (LPARAM)hRoot);
+ ok(ret, "got %d\n", ret);
+ ret = SendMessageA(hTree, TVM_SELECTITEM, TVGN_CARET, 0);
+ ok(ret, "got %d\n", ret);
+
DestroyWindow(hTree);
}
diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c
index 3ee1639..e4c465b 100644
--- a/dlls/comctl32/treeview.c
+++ b/dlls/comctl32/treeview.c
@@ -3426,7 +3426,7 @@ static void TREEVIEW_SingleExpand(TREEVIEW_INFO *infoPtr,
{
TREEVIEW_ITEM *SelItem;
- if ((infoPtr->dwStyle & TVS_SINGLEEXPAND) == 0 || infoPtr->hwndEdit) return;
+ if ((infoPtr->dwStyle & TVS_SINGLEEXPAND) == 0 || infoPtr->hwndEdit || !item) return;
TREEVIEW_SendTreeviewNotify(infoPtr, TVN_SINGLEEXPAND, TVC_UNKNOWN, TVIF_HANDLE | TVIF_PARAM, item, 0);
--
1.5.6.5
--------------040505050207020703050800--
More information about the wine-patches
mailing list