[PATCH] Silence a warning in ::get_baseName() for document nodes

Nikolay Sivov nsivov at codeweavers.com
Tue Jun 22 13:47:36 CDT 2010


---
 dlls/msxml3/node.c         |    1 +
 dlls/msxml3/tests/domdoc.c |    5 +++++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index 31c6e46..135844f 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -1632,6 +1632,7 @@ static HRESULT WINAPI xmlnode_get_baseName(
         break;
     case XML_TEXT_NODE:
     case XML_COMMENT_NODE:
+    case XML_DOCUMENT_NODE:
         break;
     default:
         ERR("Unhandled type %d\n", This->node->type );
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 605628f..d85e9fb 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -656,6 +656,11 @@ if (0)
     r = IXMLDOMDocument_get_nodeName( doc, NULL );
     ok ( r == E_INVALIDARG, "get_nodeName (NULL) wrong code\n");
 
+    str = (BSTR)0xdeadbeef;
+    r = IXMLDOMDocument_get_baseName( doc, &str );
+    ok ( r == S_FALSE, "got 0x%08x\n", r);
+    ok (str == NULL, "got %p\n", str);
+
     /* content doesn't matter here */
     str = NULL;
     r = IXMLDOMDocument_get_nodeName( doc, &str );
-- 
1.5.6.5


--------------010703020004040604000801--



More information about the wine-patches mailing list