[1/3] msvcrt.dll: Tests for getenv_s and _wgetenv_s

Piotr Caban piotr.caban at gmail.com
Sat Jun 26 16:43:55 CDT 2010


Hi,

+    p_getenv_s = (void *)GetProcAddress(hmod, "getenv_s");
+    p__wgetenv_s = (void *)GetProcAddress(hmod, "_wgetenv_s");
+    p__set_handler = (void *)GetProcAddress(hmod, 
"_set_invalid_parameter_handler");
+}

+    if (!p__set_handler)
+    {
+        skip("parameter validation support not found\n");
+        return;
+    }
_set_invalid_parameter_handler is not exported in native msvcrt (any 
version). Because of it your tests will be skipped on all systems.

Please use win_skip if tests shouldn't be skipped in wine.

You should also send implementation as first patch in serie and tests as 
second (or add and remove todo_wine).

In the second patch you left a comment saying getenv_s is not exported 
in native version. It's exported in some never versions, so please 
remove it.

Cheers,
Piotr



More information about the wine-patches mailing list