[1/3] msvcrt.dll: Tests for getenv_s and _wgetenv_s

Paul Chitescu paulc at voip.null.ro
Sun Jun 27 08:42:05 CDT 2010


On Sunday 27 June 2010 12:43:55 am Piotr Caban wrote:
> Hi,
> 
> +    p_getenv_s = (void *)GetProcAddress(hmod, "getenv_s");
> +    p__wgetenv_s = (void *)GetProcAddress(hmod, "_wgetenv_s");
> +    p__set_handler = (void *)GetProcAddress(hmod, 
> "_set_invalid_parameter_handler");
> +}
> 
> +    if (!p__set_handler)
> +    {
> +        skip("parameter validation support not found\n");
> +        return;
> +    }
> _set_invalid_parameter_handler is not exported in native msvcrt (any 
> version). Because of it your tests will be skipped on all systems.
> 
> Please use win_skip if tests shouldn't be skipped in wine.
> 
> You should also send implementation as first patch in serie and tests as 
> second (or add and remove todo_wine).
> 
> In the second patch you left a comment saying getenv_s is not exported 
> in native version. It's exported in some never versions, so please 
> remove it.
> 
> Cheers,
> Piotr

Is there any known MSVCRT version in which getenv_s is exported and 
_set_invalid_parameter_handler is not? That would not make sense. Please show 
me one dump of a msvcrt.dll that exports getenv_s but not 
_set_invalid_parameter_handler.

For testing _set_invalid_parameter_handler is mandatory since the default 
behavior in case of invalid parameters is to abort.

I intend to move all such tests to msvcr80 (or perhaps msvcr90).

Paul




More information about the wine-patches mailing list