[PATCH 1/2] cmd: Adds test cases for and implements 6 missing IF operators in cmd.exe (EQU, NEQ, GTR, GEQ, LSS, LEQ)

jgilik at ucla.edu jgilik at ucla.edu
Tue Mar 16 18:22:28 CDT 2010


I'm a CS student at UCLA working with Dan Kegel on fixing some of the  
Firefox build breaks under Wine using MSVC caused by unimplemented  
cmd.exe features.

The first of these patches add test cases to demonstrate broken IF  
functionality, where the six comparison operators GTR, LSS, GEQ, LEQ,  
EQU, and NEQ are unimplemented.  It also implements these operators,  
making these test cases pass.

The second patch fixes Makefile.in for cmd.exe to include shlwapi, as  
I needed to use some of the string functions within to implement the  

Together, these patches resolve http://bugs.winehq.org/show_bug.cgi?id=21046

John Gilik

P.S.: I'm resending this with minor revisions to the subject because I  
failed to read the line on the SubmittingPatches page regarding adding  
the module name with a colon.  Also revising the format of the [PATCH  
#/MAX] tag to match how others are submitting it.  Sorry for the  
duplicate messages.

  programs/cmd/builtins.c                  |  100 ++++++++++++-
  programs/cmd/tests/test_builtins.cmd     |  248  
  programs/cmd/tests/test_builtins.cmd.exp |  124 +++++++++++++++
  3 files changed, 471 insertions(+), 1 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adds-test-cases-for-and-implements-6-missing-IF-oper.patch
Type: text/x-patch
Size: 13587 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100316/832546c6/attachment-0001.bin>

More information about the wine-patches mailing list