mshtml/tests: Fix return value of ActiveScript_SetScriptState.

Gerald Pfeifer gerald at pfeifer.com
Sun May 2 14:16:06 CDT 2010


IActiveScriptSite_OnStateChange is described to return S_OK upon
success, so instead of ignoring its return value and unconditionally
returning S_OK it strikes me that we should return its result instead.

Gerald
---
 dlls/mshtml/tests/script.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c
index 56d83ef..dab2047 100644
--- a/dlls/mshtml/tests/script.c
+++ b/dlls/mshtml/tests/script.c
@@ -1995,7 +1995,7 @@ static HRESULT WINAPI ActiveScript_SetScriptState(IActiveScript *iface, SCRIPTST
     }
 
     hres = IActiveScriptSite_OnStateChange(site, (state = ss));
-    return S_OK;
+    return hres;
 }
 
 static HRESULT WINAPI ActiveScript_GetScriptState(IActiveScript *iface, SCRIPTSTATE *pssState)
-- 
1.6.6.2



More information about the wine-patches mailing list