[PATCH 1/2] wineoss: Supply FFFFFFFF for midiOutGetVolume, no garbage.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Tue May 4 08:43:05 CDT 2010


Hi,

This parallels the test
    ok((capsA.dwSupport & MIDICAPS_VOLUME) ? rc==MMSYSERR_NOERROR : rc==MMSYSERR_NOTSUPPORTED, "midiOutGetVolume rc=%s\n", mmsys_error(rc));
that's been in the testsuite for several month now.
Wine currently passes this tests because it's always been lying about
its volume support.  My next patch changes that.

GetVolume sets lpdwVolume in any case, so that apps that don't check
MIDICAPS don't read garbage uninitiased input that they'll
then pass to other components.

SetVolume likely behaves similar but was a) not tested b) is not
implemented in any driver in Wine, and last but not least c) is not
subject to the "process garbage data" issue.  => Unchanged.

Actually, this patch stands on its own. But the next one depends
 on it or it will generate test failures.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-wineoss-Supply-FFFFFFFF-for-midiOutGetVolume-no-garb.patch
Type: application/octet-stream
Size: 1476 bytes
Desc: 0003-wineoss-Supply-FFFFFFFF-for-midiOutGetVolume-no-garb.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100504/a570f95b/attachment.obj>


More information about the wine-patches mailing list