[1/3] richedit: Missing HeapFree in WM_IME_COMPOSITION. (Smatch)
Dylan Smith
dylan.ah.smith at gmail.com
Mon May 24 00:04:42 CDT 2010
ME_InsertTextFromCursor copies the string passed into it rather than making
taking ownership of it.
---
dlls/riched20/editor.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c
index 85e8f14..7764614 100644
--- a/dlls/riched20/editor.c
+++ b/dlls/riched20/editor.c
@@ -4268,6 +4268,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam,
ImmGetCompositionStringW(hIMC, GCS_RESULTSTR, lpCompStr, dwBufLen);
lpCompStr[dwBufLen/sizeof(WCHAR)] = 0;
ME_InsertTextFromCursor(editor,0,lpCompStr,dwBufLen/sizeof(WCHAR),style);
+ HeapFree(GetProcessHeap(), 0, lpCompStr);
}
else if (lParam & GCS_COMPSTR)
{
@@ -4280,6 +4281,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam,
lpCompStr[dwBufLen/sizeof(WCHAR)] = 0;
ME_InsertTextFromCursor(editor,0,lpCompStr,dwBufLen/sizeof(WCHAR),style);
+ HeapFree(GetProcessHeap(), 0, lpCompStr);
ME_SetSelection(editor,editor->imeStartIndex,
editor->imeStartIndex + dwBufLen/sizeof(WCHAR));
}
--
1.7.0.4
More information about the wine-patches
mailing list