[1/3] msi: Get rid of the goto in MSI_ApplicablePatchW.

Hans Leidekker hans at codeweavers.com
Tue May 25 05:18:32 CDT 2010


---
 dlls/msi/msi.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c
index afa7005..9d8a88a 100644
--- a/dlls/msi/msi.c
+++ b/dlls/msi/msi.c
@@ -541,15 +541,14 @@ static UINT MSI_ApplicablePatchW( MSIPACKAGE *package, LPCWSTR patch )
     si = MSI_GetSummaryInformationW( patch_db->storage, 0 );
     if (!si)
     {
-        r = ERROR_FUNCTION_FAILED;
-        goto done;
+        msiobj_release( &patch_db->hdr );
+        return ERROR_FUNCTION_FAILED;
     }
 
     r = msi_check_patch_applicable( package, si );
     if (r != ERROR_SUCCESS)
         TRACE("patch not applicable\n");
 
-done:
     msiobj_release( &patch_db->hdr );
     msiobj_release( &si->hdr );
     return r;
-- 
1.7.0.4







More information about the wine-patches mailing list