Updated Norwegian translation.

Fri Oct 15 10:39:33 CDT 2010

2010/10/15 Alexander Nicolaysen Sørnes <alex at thehandofagony.com>:
>  Fredag 15 oktober 2010 05:05:46 skrev Austin English :
>> 2010/10/14 Trygve Vea <trygve.vea at gmail.com>:
>> > Hello,
>> >
>> > This is my first patch to Wine - this one fixes some translation
>> > errors - and adds some new translations.
>> > I hope this is not the last patch I will send to Wine.
>> >
>> > Any feedback is welcome.
>>
>> Hello Trygve,
>>
>> Thanks for the translations. However, patches should be split, 1 patch
>> per module. In other words, one patch for dlls/crypt32, one for
>> dlls/jscript, and so on.

I've sendt new patches, where these are split up.

> It's great to see that someone else is contributing to the Norwegian
> translation. :)
>
> Your contribution is of a high quality; I only have a few comments:

Thank you for nice feedback, much appreciated :)

> General:
>
> For some files, it looks like you're only changing the character encoding. If
> so you should change to UTF-8, and add #pragma code_page(65001) at the
> beginning of the file, and then there's no reason to add copyright info.
>
> In some files you are adding copyright info when you're just fixing one or two
> typos. This is not necessary.

Noted. I haven't changed the encoding in any of the files, though. The
files that are encoded UTF8 already have the #pragma code_page(65001)
in there, and the other files are ISO8859-1:

tv at moe:~/git/wine$ file $(git diff
b20e75f5e903e5e785f0e4c6d53efe0cf2cfb74a | egrep '^--- a' | cut -c 7-)
dlls/crypt32/crypt32_No.rc:             UTF-8 Unicode C program text
dlls/cryptdlg/cryptdlg_No.rc:           UTF-8 Unicode C program text
dlls/jscript/jscript_No.rc:             UTF-8 Unicode C program text
dlls/msi/msi_No.rc:                     ISO-8859 C program text
dlls/oleaut32/oleaut32_No.rc:           ISO-8859 C program text
dlls/oledlg/oledlg_No.rc:               ISO-8859 C program text
dlls/shell32/shell32_No.rc:             UTF-8 Unicode C program text
dlls/user32/resources/user32_No.rc:     ISO-8859 C program text
dlls/wineps.drv/wps_No.rc:              ISO-8859 C program text
programs/wineboot/wineboot_No.rc:       UTF-8 Unicode C program text
programs/wineconsole/wineconsole_No.rc: ISO-8859 C program text

tv at moe:~/git/wine$ grep pragma $(git diff
b20e75f5e903e5e785f0e4c6d53efe0cf2cfb74a | egrep '^--- a' | cut -c 7-)
| awk '{ print $1 }'
dlls/crypt32/crypt32_No.rc:#pragma
dlls/cryptdlg/cryptdlg_No.rc:#pragma
dlls/jscript/jscript_No.rc:#pragma
dlls/shell32/shell32_No.rc:#pragma
programs/wineboot/wineboot_No.rc:#pragma

> jscript
> This change should be discarded; in my opinion the original is better
> (although I'm biased, since I wrote it :p )

I personally consider terminating and ending a string two different
things - hence my change. We may have to agree to disagree (?) :)

> msiexec
> -       "Register MSI Service:\n" \
> +       "Registrer MSI tjeneste:\n" \
> You should use a hyphen: MSI-tjeneste
>        "\t/y\n" \
> -       "Unregister MSI Service:\n" \
> +       "Avregistrer MSI tjeneste:\n" \
> Same as above
>        "\t/z\n" \
> -       "Display this help:\n" \
> +       "Vis denne hjelp:\n" \
> Maybe "Vis denne hjelpeteksten"?

You're right. I'll submit a new patch for this.

> oleaut32_No.rc
> It looks like you're only changing the character encoding? If so you should
> change to UTF-8, and add #pragma code_page(65001) at the beginning of the
> file.
> And in that case, there is no reason to add copyright info.

I haven't touched the encoding - it seems that this file might have
been automatically converted or something from before, and the correct
character 'å' wasn't properly converted. It's a simple correction.

> oledlg_No.rc
> -  IDS_BROWSE            "Bla"
> +  IDS_BROWSE            "Bla gjennom"
> "Bla gjennom" is indeed a better translation, but in some places I have
> shortened the text because buttons are too small. Is this not the case here?

As far as I can tell, IDS_BROWSE is only used for the titlebar of the
window, which should have room for it.  Other translations have also
concluded that there is room for 11 characters here.

> +    IDS_PS_PASTE_LINK_DATA                "Setter innholdet fra
> utklippstavlen inn i dokumentet som %s.  Det kobles til kildefilen s� endrer i
> denne ogs� skjer i dokumentet."
> "endrer" should be "endringer" (yes, this is also wrong in the original
> version :) )

Gotcha'. Will submit a new patch.

> shell32_No.rc
> -       IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.
> \n\nDo you want to replace it?"
> +       IDS_OVERWRITEFILE_TEXT "Denne mappen inneholder allerede en fil med navn
> '%1'.\n\nVil du erstatte den?"
> You should use « and » for quotation marks.

Even when the English version does not?

> -       IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named
> '%1'.\n\n"\
> -           "If the files in the destination folder have the same names as files
> in the\n"\
> -           "selected folder they will be replaced. Do you still want to move or
> copy\n"\
> -           "the folder?"
> +       IDS_OVERWRITEFOLDER_TEXT "Denne katalogen inneholder allerede en katalog
> med navn '%1'.\n\n"\
> +           "Hvis filene i katalogen du kopierer til heter det samme som filene i
> katalogen du\n"\
> +           "kopierer fra, vil disse bli erstattet. Ønsker du fortsatt å flytte
> eller kopiere\n"\
> +           "denne mappen?"
> You should be conssitent with the translation of "folder". Normally "folder" =
> "mappe" and "directory" = "katalog"

Agreed, that's a mistake I've made. I'll create a new patch for this.

> wineconsole_No.rc
> -       GROUPBOX "Control", -1, 75, 11, 125, 44, BS_GROUPBOX
> -       LTEXT "Popup menu", -1, 79, 23, 40, 10
> -       AUTOCHECKBOX "&Control", IDC_OPT_CONF_CTRL, 129, 23, 60, 10, WS_TABSTOP
> -       AUTOCHECKBOX "S&hift", IDC_OPT_CONF_SHIFT, 129, 33, 60, 10, WS_TABSTOP
> +       GROUPBOX "Kontroll", -1, 75, 11, 125, 44, BS_GROUPBOX
> +       LTEXT "Popup-meny", -1, 79, 23, 40, 10
> "Popup" is not a Norwegian word. You could simply write "Meny"

http://i18n.skulelinux.no/nb/Fellesordl.eng-no.html#popup_menu

I like Hurtigmeny.  I'll submit a new patch.

-- 
Trygve Vea