[PATCH] kernel32/tests: Fix the mixed-case short path test to actually test something.

Charles Davis cdavis at mymail.mines.edu
Thu Oct 28 18:57:48 CDT 2010


GetShortPathName() returns paths that are already uppercase. The
toupper() thus had no effect.
---
 dlls/kernel32/tests/path.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/kernel32/tests/path.c b/dlls/kernel32/tests/path.c
index 2775ab1..3d32767 100644
--- a/dlls/kernel32/tests/path.c
+++ b/dlls/kernel32/tests/path.c
@@ -571,7 +571,7 @@ static void test_ShortPathCase(const char *tmpdir, const char *dirname,
     /* Now for the real test */
     for(i=0;i<strlen(shortbuf);i++)
         if (i % 2)
-            shortbuf[i] = toupper(shortbuf[i]);
+            shortbuf[i] = tolower(shortbuf[i]);
     hndl = CreateFileA(shortbuf,GENERIC_READ|GENERIC_WRITE,0,NULL,OPEN_EXISTING,0,NULL);
     ok(hndl!=INVALID_HANDLE_VALUE,"CreateFileA failed (%d)\n",GetLastError());
     CloseHandle(hndl);
-- 
1.7.3.2




More information about the wine-patches mailing list