msvcrt:string Fix codepage table 1361 (Korean Johab) [try2]

Alexandre Goujon ale.goujon at gmail.com
Wed Sep 1 04:33:49 CDT 2010


In this version, I modified cpmap.pl instead of directly editing c_1361.c

[OffTopic]
And if you could leave a comment each time you reject a patch, we could adapt it and resend a better one.
The same for pending status : do we need to convince you or are you waiting for feedback from your developpers ?
You're always right but being (a little) more --verbose don't harm.
[/OffTopic]
---
 dlls/msvcrt/tests/string.c |   12 ++++--------
 libs/wine/cpmap.pl         |    6 +++++-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c
index ac157c3..0ee7135 100644
--- a/dlls/msvcrt/tests/string.c
+++ b/dlls/msvcrt/tests/string.c
@@ -354,16 +354,12 @@ static void test_mbcp(void)
 
     _setmbcp(1361);
     expect_eq(_ismbblead(0x80), 0, int, "%d");
-    todo_wine {
-      expect_eq(_ismbblead(0x81), 1, int, "%d");
-      expect_eq(_ismbblead(0x83), 1, int, "%d");
-    }
+    expect_eq(_ismbblead(0x81), 1, int, "%d");
+    expect_eq(_ismbblead(0x83), 1, int, "%d");
     expect_eq(_ismbblead(0x84), 1, int, "%d");
     expect_eq(_ismbblead(0xd3), 1, int, "%d");
     expect_eq(_ismbblead(0xd7), 0, int, "%d");
-    todo_wine {
-      expect_eq(_ismbblead(0xd8), 1, int, "%d");
-    }
+    expect_eq(_ismbblead(0xd8), 1, int, "%d");
     expect_eq(_ismbblead(0xd9), 1, int, "%d");
 
     expect_eq(_ismbbtrail(0x30), 0, int, "%d");
@@ -829,7 +825,7 @@ static void test_ismbclegal(void) {
             break;
         }
     }
-    todo_wine ok(!err, "_ismbclegal (1361) : Expected 0x%x, got 0x%x (0x%x)\n", exp, ret, i);
+    ok(!err, "_ismbclegal (1361) : Expected 0x%x, got 0x%x (0x%x)\n", exp, ret, i);
 
     _setmbcp(prev_cp);
 }
diff --git a/libs/wine/cpmap.pl b/libs/wine/cpmap.pl
index 79f5fd5..ff973c9 100755
--- a/libs/wine/cpmap.pl
+++ b/libs/wine/cpmap.pl
@@ -1527,6 +1527,7 @@ sub handle_bestfit_file($$$)
 sub HANDLE_FILE(@)
 {
     my ($codepage,$filename,$has_glyphs,$comment) = @_;
+    my @lb_ranges = ();
 
     @cp2uni = ();
     @lead_bytes = ();
@@ -1563,8 +1564,11 @@ sub HANDLE_FILE(@)
     }
     printf OUTPUT "#include \"wine/unicode.h\"\n\n";
 
+    if( $codepage == 1361 ) { @lb_ranges =  ( 0x81, 0xd3, 0xd8, 0xde, 0xe0, 0xf9 ); }
+    else { @lb_ranges = get_lb_ranges(); }
+
     if (!@lead_bytes) { dump_sbcs_table( $codepage, $has_glyphs, $comment, $DEF_CHAR, $DEF_CHAR ); }
-    else { dump_dbcs_table( $codepage, $comment, $DEF_CHAR, $DEF_CHAR, get_lb_ranges() ); }
+    else { dump_dbcs_table( $codepage, $comment, $DEF_CHAR, $DEF_CHAR, @lb_ranges ); }
     close OUTPUT;
     save_file($output);
 }
-- 
1.7.0.4




More information about the wine-patches mailing list