[PATCH 1/2] wined3d: Add argument check for Type to Get/SetTextureStageState().

Rico Schüller kgbricola at web.de
Sun Sep 12 03:34:20 CDT 2010


this patch add in argument check for the Type to 
Get/SetTextureStageState(). It seems that some apps simply loop trough 
all values, which could crash because we index the array with a to high 
index (see bug 24249).

I've not added a test, because you could get an unhandled page fault on 
read access in the case of GetTextureStageState() (it depends on the 
type and state value).


  dlls/d3d8/device.c    |   26 ++++++++++++++++++++++----
  dlls/d3d9/device.c    |   18 ++++++++++++++++--
  dlls/ddraw/device.c   |    9 ++++++---
  dlls/wined3d/device.c |   23 ++++++++++++++++++++---
  4 files changed, 64 insertions(+), 12 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wined3d-Add-argument-check-for-Type-to-Get-SetTextureS.txt
Type: text/x-patch
Size: 8345 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100912/b263dd27/attachment.bin>

More information about the wine-patches mailing list