[PATCH 1/3] winmm: Memory related fixes.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Wed Aug 3 07:30:39 CDT 2011


Hi,

IMHO, this does not need further splitting.  We have had that big 100KB patch which introduced
the bugs and don't need N patches of a fraction that size each to fix them one by one.
Instead, we need to find and remove them quickly so users can be happy again with sound in Wine.

I hope the "obviously correct" argument still has weight and value.

- Allocate passed_fmt on stack
- Remove superfluous (unused) memcpy &cb_info
- Fix one ACM leak in error path
- Use C struct copy instead of memcpy &cb_info

Regards,
 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-winmm-Memory-related-fixes.patch
Type: application/octet-stream
Size: 7013 bytes
Desc: 0002-winmm-Memory-related-fixes.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20110803/e225c8c4/attachment.obj>


More information about the wine-patches mailing list