[PATCH] mshtml: also return a valid hres in error case (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Aug 6 05:00:41 CDT 2011


Hi,

the else codepath did have an uninitialized hres. CID 5282

Ciao, Marcus
---
 dlls/mshtml/htmlanchor.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/mshtml/htmlanchor.c b/dlls/mshtml/htmlanchor.c
index c369ed5..60f0c3e 100644
--- a/dlls/mshtml/htmlanchor.c
+++ b/dlls/mshtml/htmlanchor.c
@@ -74,6 +74,8 @@ static HRESULT navigate_anchor(HTMLAnchorElement *This)
             TRACE("empty href\n");
             hres = S_OK;
         }
+    } else {
+        hres = E_FAIL;
     }
     nsAString_Finish(&href_str);
     return hres;
-- 
1.7.3.4




More information about the wine-patches mailing list