comctl32: Avoid using uninitialized value (Coverity) (try 2)

Frédéric Delanoy frederic.delanoy at gmail.com
Thu Dec 15 08:41:10 CST 2011


CID 4640

try 2: Setting class style is unneeded since it is already set in GetClassInfoExW
Add error checking for GetClassInfoExW call
---
 dlls/comctl32/theming.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/dlls/comctl32/theming.c b/dlls/comctl32/theming.c
index 3ff6814..aa99fc1 100644
--- a/dlls/comctl32/theming.c
+++ b/dlls/comctl32/theming.c
@@ -129,8 +129,12 @@ void THEMING_Initialize (void)
         WNDCLASSEXW class;
 
         class.cbSize = sizeof(class);
-        class.style |= CS_GLOBALCLASS;
-        GetClassInfoExW (NULL, subclasses[i].className, &class);
+        if (!GetClassInfoExW (NULL, subclasses[i].className, &class))
+        {
+            ERR("Could not retrieve information for class %s\n",
+                debugstr_w (subclasses[i].className));
+            continue;
+        }
         originalProcs[i] = class.lpfnWndProc;
         class.lpfnWndProc = subclassProcs[i];
         
-- 
1.7.8




More information about the wine-patches mailing list