[PATCH 2/2] comdlg32: Widen buffer to accomodate Catalan translation

Francois Gouget fgouget at free.fr
Fri Dec 16 04:49:49 CST 2011

On Fri, 16 Dec 2011, Alex Henrie wrote:

> ---
>  dlls/comdlg32/filedlg.c |    2 +-
> -      WCHAR buf[16];
> +      WCHAR buf[17];
>        LoadStringW(COMDLG32_hInstance, IDS_SAVE_AS, buf, sizeof(buf)/sizeof(WCHAR));

I don't think it makes sense to add room for just one more WCHAR. 
There's no telling how long a future Arabic or Panjabi translation might 
be. So either set the buffer size to something like 80, 128 or 256 
characters (sucks 5, 8 and 16 times less respectively), or do away with 
the hardcoded buffer size altogether (overkill? rocks? both?<g>).

Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
      Broadcast message : fin du monde dans cinq minutes, repentez vous !

More information about the wine-patches mailing list