[PATCH] gdi32: check return value of REGION_UnionRectWithRegion (Coverity)
Marcus Meissner
marcus at jet.franken.de
Sat Dec 31 09:21:48 CST 2011
Hi,
Pass it down, even though its not checked by callers.
CID 5502.
Ciao, Marcus
---
dlls/gdi32/region.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/dlls/gdi32/region.c b/dlls/gdi32/region.c
index 4daf88c..66ca1c3 100644
--- a/dlls/gdi32/region.c
+++ b/dlls/gdi32/region.c
@@ -1271,11 +1271,12 @@ static BOOL REGION_UnionRectWithRegion(const RECT *rect, WINEREGION *rgn)
BOOL add_rect_to_region( HRGN rgn, const RECT *rect )
{
RGNOBJ *obj = GDI_GetObjPtr( rgn, OBJ_REGION );
+ BOOL ret;
if (!obj) return FALSE;
- REGION_UnionRectWithRegion( rect, &obj->rgn );
+ ret = REGION_UnionRectWithRegion( rect, &obj->rgn );
GDI_ReleaseObj( rgn );
- return TRUE;
+ return ret;
}
/***********************************************************************
--
1.7.3.4
More information about the wine-patches
mailing list