winmm: Simplify MCI_DumpCommandTable a bit. (RETRY)

Gerald Pfeifer gerald at pfeifer.com
Tue Feb 15 19:23:09 CST 2011


Ping.  Any objection to this, given that this has not been used for
quite a while?
 
---------- Forwarded message ----------
From: Gerald Pfeifer <gerald at pfeifer.com>
To: wine-patches at winehq.org
Date: Sat, 5 Feb 2011 01:07:25 +0100 (CET)
Subject: Re: winmm: Simplify MCI_DumpCommandTable a bit.

On Tue, 4 May 2010, Gerald Pfeifer wrote:
> I am not sure about this.  Perhaps remove the TRACE, which is disabled,
> altogether, remove this part of the output from TRACE (since it is not
> used otherwise), or at least move flg to an innermore level as other
> options?

Since I just ran into this again, I recalled my patch from last year
where I did not see any response.

How about this?

Gerald


diff --git a/dlls/winmm/mci.c b/dlls/winmm/mci.c
index 30db363..61f1bea 100644
--- a/dlls/winmm/mci.c
+++ b/dlls/winmm/mci.c
@@ -625,7 +625,6 @@ static	BOOL		MCI_DumpCommandTable(UINT uTbl)
 {
     const BYTE*	lmem;
     LPCWSTR	str;
-    DWORD	flg;
     WORD	eid;
 
     if (!MCI_IsCommandTableValid(uTbl)) {
@@ -638,9 +637,9 @@ static	BOOL		MCI_DumpCommandTable(UINT uTbl)
 	do {
 	    str = (LPCWSTR)lmem;
 	    lmem += (strlenW(str) + 1) * sizeof(WCHAR);
-	    flg = *(const DWORD*)lmem;
 	    eid = *(const WORD*)(lmem + sizeof(DWORD));
-            /* TRACE("cmd=%s %08lx %04x\n", debugstr_w(str), flg, eid); */
+            /* TRACE("cmd=%s %08lx %04x\n",
+                     debugstr_w(str), *(const DWORD*)lmem, eid); */
 	    lmem += sizeof(DWORD) + sizeof(WORD);
 	} while (eid != MCI_END_COMMAND && eid != MCI_END_COMMAND_LIST);
         /* EPP TRACE(" => end of command%s\n", (eid == MCI_END_COMMAND_LIST) ? " list" : ""); */



More information about the wine-patches mailing list