comctl32/tests: make sure to use return values (LLVM/Clang) (try 2)

Austin English austinenglish at gmail.com
Wed Feb 16 23:54:14 CST 2011


I removed the hittest change, not sure what it should be returning.
Needs more investigation (or perhaps for Nikolay to take a look :)).

-- 
-Austin
-------------- next part --------------
diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c
index a4ffa2e..d818b62 100644
--- a/dlls/comctl32/tests/listview.c
+++ b/dlls/comctl32/tests/listview.c
@@ -744,8 +744,9 @@ static void test_images(void)
     r = SendMessage(hwnd, LVM_SETIMAGELIST, 0, (LPARAM)himl);
     ok(r == 0, "should return zero\n");
 
-    r = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELONG(100,50));
     /* returns dimensions */
+    r = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELONG(100,50));
+    ok(r, "failed\n");
 
     r = SendMessage(hwnd, LVM_GETITEMCOUNT, 0, 0);
     ok(r == 0, "should be zero items\n");
@@ -977,6 +978,7 @@ static void test_checkboxes(void)
     item.mask = LVIF_STATE;
     item.stateMask = 0xffff;
     r = SendMessage(hwnd, LVM_GETITEMA, 0, (LPARAM) &item);
+    expect(1, r);
     ok(item.state == 0x1aab, "state %x\n", item.state);
 
     DestroyWindow(hwnd);
@@ -3757,6 +3759,7 @@ static void test_notifyformat(void)
     r = SendMessage(hwnd, LVM_GETUNICODEFORMAT, 0, 0);
     expect(0, r);
     r = SendMessage(hwnd, WM_NOTIFYFORMAT, 0, NF_QUERY);
+    todo_wine expect(2, r);
     /* set */
     r = SendMessage(hwnd, LVM_SETUNICODEFORMAT, 1, 0);
     expect(0, r);


More information about the wine-patches mailing list