[PATCH] rsaenh: Fixed bad sizeof() usage (Coverity)
Marcus Meissner
meissner at suse.de
Tue Feb 22 22:14:38 CST 2011
Hi,
Fixes CID 1186-1191, copy and pasted sizeof() badness.
Ciao, Marcus
---
dlls/rsaenh/sha2.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/dlls/rsaenh/sha2.c b/dlls/rsaenh/sha2.c
index ea5bb28..76e7184 100644
--- a/dlls/rsaenh/sha2.c
+++ b/dlls/rsaenh/sha2.c
@@ -563,7 +563,7 @@ void SHA256_Final(sha2_byte digest[], SHA256_CTX* context) {
}
/* Clean up state data: */
- MEMSET_BZERO(context, sizeof(context));
+ MEMSET_BZERO(context, sizeof(*context));
usedspace = 0;
}
@@ -584,7 +584,7 @@ char *SHA256_End(SHA256_CTX* context, char buffer[]) {
}
*buffer = 0;
} else {
- MEMSET_BZERO(context, sizeof(context));
+ MEMSET_BZERO(context, sizeof(*context));
}
MEMSET_BZERO(digest, SHA256_DIGEST_LENGTH);
return buffer;
@@ -893,7 +893,7 @@ void SHA512_Final(sha2_byte digest[], SHA512_CTX* context) {
}
/* Zero out state data */
- MEMSET_BZERO(context, sizeof(context));
+ MEMSET_BZERO(context, sizeof(*context));
}
char *SHA512_End(SHA512_CTX* context, char buffer[]) {
@@ -913,7 +913,7 @@ char *SHA512_End(SHA512_CTX* context, char buffer[]) {
}
*buffer = 0;
} else {
- MEMSET_BZERO(context, sizeof(context));
+ MEMSET_BZERO(context, sizeof(*context));
}
MEMSET_BZERO(digest, SHA512_DIGEST_LENGTH);
return buffer;
@@ -968,7 +968,7 @@ void SHA384_Final(sha2_byte digest[], SHA384_CTX* context) {
}
/* Zero out state data */
- MEMSET_BZERO(context, sizeof(context));
+ MEMSET_BZERO(context, sizeof(*context));
}
char *SHA384_End(SHA384_CTX* context, char buffer[]) {
@@ -988,7 +988,7 @@ char *SHA384_End(SHA384_CTX* context, char buffer[]) {
}
*buffer = 0;
} else {
- MEMSET_BZERO(context, sizeof(context));
+ MEMSET_BZERO(context, sizeof(*context));
}
MEMSET_BZERO(digest, SHA384_DIGEST_LENGTH);
return buffer;
--
1.7.1
More information about the wine-patches
mailing list