[PATCH] cryptui: fixed bad sizeof() (Coverity)

Marcus Meissner meissner at suse.de
Tue Feb 22 22:30:38 CST 2011


Hi,

CID 1181. copying a pointer to a struct into a struct is likely bad,
fixed.

Ciao, Marcus
---
 dlls/cryptui/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c
index b823b6e..16f53da 100644
--- a/dlls/cryptui/main.c
+++ b/dlls/cryptui/main.c
@@ -1637,7 +1637,7 @@ HCERTSTORE WINAPI CryptUIDlgSelectStoreA(PCRYPTUI_SELECTSTORE_INFO_A info)
         SetLastError(E_INVALIDARG);
         return NULL;
     }
-    memcpy(&infoW, &info, sizeof(info));
+    memcpy(&infoW, info, sizeof(*info));
     if (info->pszTitle)
     {
         len = MultiByteToWideChar(CP_ACP, 0, info->pszTitle, -1, NULL, 0);
-- 
1.7.1



More information about the wine-patches mailing list