[PATCH 5/5] Use array index after range check (Coverity)
Nikolay Sivov
nsivov at codeweavers.com
Fri Feb 25 03:01:12 CST 2011
---
dlls/comctl32/ipaddress.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/dlls/comctl32/ipaddress.c b/dlls/comctl32/ipaddress.c
index 1f41f91..ee8a31d 100644
--- a/dlls/comctl32/ipaddress.c
+++ b/dlls/comctl32/ipaddress.c
@@ -384,15 +384,16 @@ static void IPADDRESS_SetFocusToField (const IPADDRESS_INFO *infoPtr, INT index)
static BOOL IPADDRESS_ConstrainField (const IPADDRESS_INFO *infoPtr, int currentfield)
{
- const IPPART_INFO *part = &infoPtr->Part[currentfield];
- WCHAR field[10];
static const WCHAR fmt[] = { '%', 'd', 0 };
+ const IPPART_INFO *part;
int curValue, newValue;
+ WCHAR field[10];
TRACE("(currentfield=%d)\n", currentfield);
if (currentfield < 0 || currentfield > 3) return FALSE;
+ part = &infoPtr->Part[currentfield];
if (!GetWindowTextW (part->EditHwnd, field, 4)) return FALSE;
curValue = atoiW(field);
--
1.5.6.5
--------------030603010701090105020600--
More information about the wine-patches
mailing list