mshtml: Handle the failure case in get_nsstyle_attr (TAKE 2)

Gerald Pfeifer gerald at pfeifer.com
Sat Jul 23 18:45:14 CDT 2011


On Mon, 18 Jul 2011, Jacek Caban wrote:
> Good catch, but you add a leak here.

Thanks, Jacek.  I hope this one is better?

Gerald


---
 dlls/mshtml/htmlstyle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
index ae2cf93..027a2fb 100644
--- a/dlls/mshtml/htmlstyle.c
+++ b/dlls/mshtml/htmlstyle.c
@@ -480,7 +480,7 @@ HRESULT get_nsstyle_attr(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, BSTR
     nsAString_Finish(&str_value);
 
     TRACE("%s -> %s\n", debugstr_w(style_tbl[sid].name), debugstr_w(*p));
-    return S_OK;
+    return hres;
 }
 
 HRESULT get_nsstyle_attr_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, VARIANT *p, DWORD flags)
-- 
1.7.3.5




More information about the wine-patches mailing list