mshtml: Remove variable which is only set from set_downloading_proc.

Jacek Caban jacek at codeweavers.com
Tue Jul 26 03:58:17 CDT 2011


Hi Gerald,

On 07/26/11 00:50, Gerald Pfeifer wrote:
> Or were you planning to add some error handling here, Jacek?
>
> Gerald
> ---
>  dlls/mshtml/persist.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c
> index 550414f..7d82a36 100644
> --- a/dlls/mshtml/persist.c
> +++ b/dlls/mshtml/persist.c
> @@ -161,7 +161,6 @@ static void set_downloading_proc(task_t *_task)
>  {
>      download_proc_task_t *task = (download_proc_task_t*)_task;
>      HTMLDocumentObj *doc = task->doc;
> -    HRESULT hres;
>  
>      TRACE("(%p)\n", doc);
>  
> @@ -180,7 +179,7 @@ static void set_downloading_proc(task_t *_task)
>      if(doc->hostui) {
>          IDropTarget *drop_target = NULL;
>  
> -        hres = IDocHostUIHandler_GetDropTarget(doc->hostui, NULL /* FIXME */, &drop_target);
> +        IDocHostUIHandler_GetDropTarget(doc->hostui, NULL /* FIXME */, &drop_target);
>          if(drop_target) {
>              FIXME("Use IDropTarget\n");
>              IDropTarget_Release(drop_target);

hres should be tested together with drop_target in the if statement.


Jacek



More information about the wine-patches mailing list