[PATCH] mscvrt: Do not shadow fmt (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Jun 14 06:06:08 CDT 2011


Hi,

Express that this fmt is different from the parameter fmt.
CID 5053.

Ciao, Marcus
---
 dlls/msvcrt/printf.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/msvcrt/printf.h b/dlls/msvcrt/printf.h
index eefecd1..efdd8aa 100644
--- a/dlls/msvcrt/printf.h
+++ b/dlls/msvcrt/printf.h
@@ -533,7 +533,7 @@ int FUNC_NAME(pf_printf)(FUNC_NAME(puts_clbk) pf_puts, void *puts_ctx, const API
             if(tmp != buf)
                 HeapFree(GetProcessHeap(), 0, tmp);
         } else if(flags.Format && strchr("aeEfgG", flags.Format)) {
-            char fmt[20], buf_a[32], *tmp = buf_a, *decimal_point;
+            char fmt2[20], buf_a[32], *tmp = buf_a, *decimal_point;
             int max_len = (flags.FieldLength>flags.Precision ? flags.FieldLength : flags.Precision) + 10;
 
             if(max_len > sizeof(buf_a))
@@ -541,9 +541,9 @@ int FUNC_NAME(pf_printf)(FUNC_NAME(puts_clbk) pf_puts, void *puts_ctx, const API
             if(!tmp)
                 return -1;
 
-            FUNC_NAME(pf_rebuild_format_string)(fmt, &flags);
+            FUNC_NAME(pf_rebuild_format_string)(fmt2, &flags);
 
-            sprintf(tmp, fmt, pf_args(args_ctx, pos, VT_R8, valist).get_double);
+            sprintf(tmp, fmt2, pf_args(args_ctx, pos, VT_R8, valist).get_double);
             if(toupper(flags.Format)=='E' || toupper(flags.Format)=='G')
                 FUNC_NAME(pf_fixup_exponent)(tmp);
 
-- 
1.7.3.4




More information about the wine-patches mailing list