[PATCH] d3dxof: Check returns of read_bytes (Coverity)
Marcus Meissner
marcus at jet.franken.de
Thu Jun 16 10:47:52 CDT 2011
Hi,
Coverity sees this 19 of 22 times checked, so check it
here too.
CID 5134.
Ciao, Marcus
---
dlls/d3dxof/parsing.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c
index cbf1761..55ab45d 100644
--- a/dlls/d3dxof/parsing.c
+++ b/dlls/d3dxof/parsing.c
@@ -233,8 +233,10 @@ HRESULT parse_header(parse_buffer * buf, BYTE ** decomp_buffer_ptr)
buf->rem_bytes -= sizeof(WORD) * 2;
buf->buffer += sizeof(WORD) * 2;
- read_bytes(buf, &decomp_size, sizeof(decomp_size));
- read_bytes(buf, &comp_size, sizeof(comp_size));
+ if (!read_bytes(buf, &decomp_size, sizeof(decomp_size)))
+ return DXFILEERR_BADFILETYPE;
+ if (!read_bytes(buf, &comp_size, sizeof(comp_size)))
+ return DXFILEERR_BADFILETYPE;
TRACE("Compressed format %s detected: compressed_size = %x, decompressed_size = %x\n",
debugstr_fourcc(header[2]), comp_size, decomp_size);
--
1.7.3.4
More information about the wine-patches
mailing list