[PATCH] strmbase: Move NULL check up a bit (Coverity)
Marcus Meissner
marcus at jet.franken.de
Sun Jun 26 09:32:39 CDT 2011
Hi,
we ZeroMemory the pointer before we check it against NULL,
reverse the checks. CID 2018.
Ciao, Marcus
---
dlls/strmbase/transform.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/dlls/strmbase/transform.c b/dlls/strmbase/transform.c
index cfde074..791d27e 100644
--- a/dlls/strmbase/transform.c
+++ b/dlls/strmbase/transform.c
@@ -222,11 +222,12 @@ HRESULT TransformFilter_Construct(const IBaseFilterVtbl *pVtbl, LONG filter_size
assert(filter_size >= sizeof(TransformFilter));
pTf = CoTaskMemAlloc(filter_size);
- ZeroMemory(pTf, filter_size);
if (!pTf)
return E_OUTOFMEMORY;
+ ZeroMemory(pTf, filter_size);
+
if (SUCCEEDED(TransformFilter_Init(pVtbl, pClsid, pFuncsTable, pTf)))
{
*ppTransformFilter = (IBaseFilter*)(&pTf->filter.lpVtbl);
--
1.7.3.4
More information about the wine-patches
mailing list