[PATCH 3/5] jscript: Support VT_UI4 in to_number

Jacek Caban jacek at codeweavers.com
Mon Jun 27 04:57:31 CDT 2011


Hi Detlef,

On 06/26/11 18:28, Detlef Riekenberg wrote:
> ---
>  dlls/jscript/jsutils.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/jscript/jsutils.c b/dlls/jscript/jsutils.c
> index d795e7d..810b303 100644
> --- a/dlls/jscript/jsutils.c
> +++ b/dlls/jscript/jsutils.c
> @@ -412,6 +412,7 @@ HRESULT to_number(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, VARIANT *ret)
>          V_I4(ret) = 0;
>          break;
>      case VT_I4:
> +    case VT_UI4:
>      case VT_R8:
>          *ret = *v;
>          break;

You can't do that, callers expect return value to be VT_I4 or VT_R8.
Also tests, please.


Jacek



More information about the wine-patches mailing list