[PATCH] urlmon: Fixed array size check (Coverity)

Marcus Meissner meissner at suse.de
Mon Jun 27 06:21:40 CDT 2011


Hi,

CID 5183

Ciao, Marcus
---
 dlls/urlmon/umon.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/urlmon/umon.c b/dlls/urlmon/umon.c
index d3eb44e..3e43bb8 100644
--- a/dlls/urlmon/umon.c
+++ b/dlls/urlmon/umon.c
@@ -612,7 +612,7 @@ HRESULT WINAPI CreateURLMonikerEx(IMoniker *pmkContext, LPCWSTR szURL, IMoniker
     if (!szURL || !ppmk)
         return E_INVALIDARG;
 
-    if(dwFlags > sizeof(create_flags_map)/sizeof(*create_flags_map)) {
+    if(dwFlags >= sizeof(create_flags_map)/sizeof(*create_flags_map)) {
         FIXME("Unsupported flags %x\n", dwFlags);
         return E_INVALIDARG;
     }
@@ -665,7 +665,7 @@ HRESULT WINAPI CreateURLMonikerEx2(IMoniker *pmkContext, IUri *pUri, IMoniker **
     if (!pUri || !ppmk)
         return E_INVALIDARG;
 
-    if(dwFlags > sizeof(create_flags_map)/sizeof(*create_flags_map)) {
+    if(dwFlags >= sizeof(create_flags_map)/sizeof(*create_flags_map)) {
         FIXME("Unsupported flags %x\n", dwFlags);
         return E_INVALIDARG;
     }
-- 
1.7.1




More information about the wine-patches mailing list