[PATCH] krnl386.exe16: Fixed if that always succeeds (Coverity)
Marcus Meissner
meissner at suse.de
Wed May 11 07:36:16 CDT 2011
Hi,
the SEL() macro uses |1 , so dgroup is never 0 and this
if always falls through.
CID 1446
Ciao, Marcus
---
dlls/krnl386.exe16/ne_segment.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/dlls/krnl386.exe16/ne_segment.c b/dlls/krnl386.exe16/ne_segment.c
index d231fb9..1ceb714 100644
--- a/dlls/krnl386.exe16/ne_segment.c
+++ b/dlls/krnl386.exe16/ne_segment.c
@@ -533,7 +533,8 @@ static void NE_FixupSegmentPrologs(NE_MODULE *pModule, WORD segnum)
if (!pModule->ne_autodata) return;
- if (!(dgroup = SEL(pSegTable[pModule->ne_autodata-1].hSeg))) return;
+ if (!pSegTable[pModule->ne_autodata-1].hSeg) return;
+ dgroup = SEL(pSegTable[pModule->ne_autodata-1].hSeg);
pSeg = MapSL( MAKESEGPTR(sel, 0) );
--
1.7.1
More information about the wine-patches
mailing list