winealsa.drv: Remove redundant NULL checks before free. (Smatch)

Michael Stefaniuc mstefani at redhat.de
Mon Oct 10 17:03:50 CDT 2011


---
 dlls/winealsa.drv/mmdevdrv.c |   18 ++++++------------
 1 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c
index 262942f..dee6ebb 100644
--- a/dlls/winealsa.drv/mmdevdrv.c
+++ b/dlls/winealsa.drv/mmdevdrv.c
@@ -1093,18 +1093,12 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface,
 exit:
     HeapFree(GetProcessHeap(), 0, sw_params);
     if(FAILED(hr)){
-        if(This->local_buffer){
-            HeapFree(GetProcessHeap(), 0, This->local_buffer);
-            This->local_buffer = NULL;
-        }
-        if(This->fmt){
-            CoTaskMemFree(This->fmt);
-            This->fmt = NULL;
-        }
-        if(This->vols){
-            HeapFree(GetProcessHeap(), 0, This->vols);
-            This->vols = NULL;
-        }
+        HeapFree(GetProcessHeap(), 0, This->local_buffer);
+        This->local_buffer = NULL;
+        CoTaskMemFree(This->fmt);
+        This->fmt = NULL;
+        HeapFree(GetProcessHeap(), 0, This->vols);
+        This->vols = NULL;
     }
 
     LeaveCriticalSection(&This->lock);
-- 
1.7.6.4



More information about the wine-patches mailing list