[PATCH] ddraw: lowercase variable names to fix a incorrect sizeof() (Coverity)

Marcus Meissner meissner at suse.de
Mon Oct 17 22:40:38 CDT 2011


Hi,

sizeof() was called incorrectly here.

I leave the place and why as an exercise to the reader.
CID3769

Ciao, Marcus
---
 dlls/ddraw/main.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c
index 4bead03..08624d1 100644
--- a/dlls/ddraw/main.c
+++ b/dlls/ddraw/main.c
@@ -296,27 +296,27 @@ DirectDrawCreate(GUID *GUID,
  *
  ***********************************************************************/
 HRESULT WINAPI DECLSPEC_HOTPATCH
-DirectDrawCreateEx(GUID *GUID,
-                   LPVOID *DD,
+DirectDrawCreateEx(GUID *guid,
+                   LPVOID *dd,
                    REFIID iid,
                    IUnknown *UnkOuter)
 {
     HRESULT hr;
 
     TRACE("driver_guid %s, ddraw %p, interface_iid %s, outer_unknown %p.\n",
-            debugstr_guid(GUID), DD, debugstr_guid(iid), UnkOuter);
+            debugstr_guid(guid), dd, debugstr_guid(iid), UnkOuter);
 
     if (!IsEqualGUID(iid, &IID_IDirectDraw7))
         return DDERR_INVALIDPARAMS;
 
     EnterCriticalSection(&ddraw_cs);
-    hr = DDRAW_Create(GUID, DD, UnkOuter, iid);
+    hr = DDRAW_Create(guid, dd, UnkOuter, iid);
     LeaveCriticalSection(&ddraw_cs);
 
     if (SUCCEEDED(hr))
     {
-        IDirectDraw7 *ddraw7 = *(IDirectDraw7 **)DD;
-        hr = IDirectDraw7_Initialize(ddraw7, GUID);
+        IDirectDraw7 *ddraw7 = *(IDirectDraw7 **)dd;
+        hr = IDirectDraw7_Initialize(ddraw7, guid);
         if (FAILED(hr))
             IDirectDraw7_Release(ddraw7);
     }
-- 
1.7.1




More information about the wine-patches mailing list