shell32: Use wine_dbgstr_rect() to trace a potentially NULL rect struct. (try 2)

Francois Gouget fgouget at free.fr
Sun Sep 18 15:52:58 CDT 2011


---

Thanks to Octavian's suggestion this is a much better version of 
this patch:
   'shell32: Don't dereference NULL pointers when tracing.'

 dlls/shell32/shlview.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c
index 3f18256..ff5f05c 100644
--- a/dlls/shell32/shlview.c
+++ b/dlls/shell32/shlview.c
@@ -2095,9 +2095,7 @@ static HRESULT WINAPI IShellView2_fnCreateViewWindow2(IShellView2 *iface,
 
     TRACE("-- psvPrev %p, pfs %p, psbOwner %p, prcView %p\n",
             view_params->psvPrev, view_params->pfs, view_params->psbOwner, view_params->prcView);
-    TRACE("-- vmode %#x, flags %#x, left %d, top %d, right %d, bottom %d\n",
-            view_params->pfs->ViewMode, view_params->pfs->fFlags, view_params->prcView->left,
-            view_params->prcView->top, view_params->prcView->right, view_params->prcView->bottom);
+    TRACE("-- vmode %#x, flags %#x, view %s\n", view_params->pfs->ViewMode, view_params->pfs->fFlags, wine_dbgstr_rect(view_params->prcView));
 
     if (!view_params->psbOwner) return E_UNEXPECTED;
 
-- 
1.7.5.4



More information about the wine-patches mailing list