[PATCH] server: removed NULL check after usage (Coverity)

Marcus Meissner meissner at suse.de
Thu Sep 22 19:11:57 CDT 2011


Hi,

queue->input is dereferenced some lines above, so this
check is not useful.
CID 5184

Ciao, Marcus
---
 server/queue.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/server/queue.c b/server/queue.c
index 3fa546e..7de6d88 100644
--- a/server/queue.c
+++ b/server/queue.c
@@ -957,11 +957,8 @@ static void msg_queue_destroy( struct object *obj )
         free( timer );
     }
     if (queue->timeout) remove_timeout_user( queue->timeout );
-    if (queue->input)
-    {
-        queue->input->cursor_count -= queue->cursor_count;
-        release_object( queue->input );
-    }
+    queue->input->cursor_count -= queue->cursor_count;
+    release_object( queue->input );
     if (queue->hooks) release_object( queue->hooks );
     if (queue->fd) release_object( queue->fd );
 }
-- 
1.7.1




More information about the wine-patches mailing list