[PATCH] kernel32/tests: Mark NT4 behavior as broken

Detlef Riekenberg wine.dev at web.de
Sun Aug 5 13:58:36 CDT 2012


--
By by ... Detlef
---
 dlls/kernel32/tests/format_msg.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/tests/format_msg.c b/dlls/kernel32/tests/format_msg.c
index 50e13f4..1a22d5b 100644
--- a/dlls/kernel32/tests/format_msg.c
+++ b/dlls/kernel32/tests/format_msg.c
@@ -1566,7 +1566,8 @@ static void test_message_invalid_flags(void)
     ptr = (char *)0xdeadbeef;
     ret = FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER, "test", 0, 0, (char *)&ptr, 0, NULL);
     ok(ret == 0, "Expected FormatMessageA to return 0, got %u\n", ret);
-    ok(ptr == NULL, "Expected output pointer to be initialized to NULL, got %p\n", ptr);
+    /* NT4 before SP2 does not set the output pointer to NULL */
+    ok(ptr == NULL || broken(ptr == 0xdeadbeef), "Expected output pointer to be initialized to NULL, got %p\n", ptr);
     ok(GetLastError() == ERROR_INVALID_PARAMETER,
        "Expected GetLastError() to return ERROR_INVALID_PARAMETER, got %u\n",
        GetLastError());
@@ -1651,7 +1652,9 @@ static void test_message_invalid_flags_wide(void)
     ptr = (WCHAR *)0xdeadbeef;
     ret = FormatMessageW(FORMAT_MESSAGE_ALLOCATE_BUFFER, test, 0, 0, (WCHAR *)&ptr, 0, NULL);
     ok(ret == 0, "Expected FormatMessageW to return 0, got %u\n", ret);
-    ok(ptr == NULL, "Expected output pointer to be initialized to NULL, got %p\n", ptr);
+    /* NT4 before SP2 does not set the output pointer to NULL */
+    ok(ptr == NULL || broken(ptr == 0xdeadbeef), "Expected output pointer to be initialized to NULL, got %p\n", ptr);
+
     ok(GetLastError() == ERROR_INVALID_PARAMETER,
        "Expected GetLastError() to return ERROR_INVALID_PARAMETER, got %u\n",
        GetLastError());
-- 
1.7.5.4




More information about the wine-patches mailing list