[PATCH] joy.cpl: avoid uninitialized variable usage (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Aug 18 04:51:24 CDT 2012


Not a real bug, as multiplication on unininitialized vars
is fine, but fix anyway. CID 715800, 715799
---
 dlls/joy.cpl/main.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/joy.cpl/main.c b/dlls/joy.cpl/main.c
index 354dfd7..b84a0aa 100644
--- a/dlls/joy.cpl/main.c
+++ b/dlls/joy.cpl/main.c
@@ -289,6 +289,7 @@ static DWORD WINAPI input_thread(void *param)
 
             r.left = (TEST_AXIS_X + TEST_NEXT_AXIS_X*i + axes_pos[i][0]);
             r.top = (TEST_AXIS_Y + axes_pos[i][1]);
+            r.bottom = r.right = 0; /* unused */
             MapDialogRect(data->graphics.hwnd, &r);
 
             SetWindowPos(data->graphics.axes[i], 0, r.left, r.top, 0, 0, SWP_NOZORDER | SWP_NOSIZE);
@@ -549,6 +550,7 @@ static DWORD WINAPI ff_input_thread(void *param)
 
         r.left = FF_AXIS_X + state.lX;
         r.top = FF_AXIS_Y + state.lY;
+        r.right = r.bottom = 0; /* unused */
         MapDialogRect(data->graphics.hwnd, &r);
 
         SetWindowPos(data->graphics.ff_axis, 0, r.left, r.top, 0, 0, SWP_NOZORDER | SWP_NOSIZE);
-- 
1.7.3.4




More information about the wine-patches mailing list